Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DocNavbarItem error message #4554

Merged
merged 3 commits into from
Apr 2, 2021
Merged

fix: DocNavbarItem error message #4554

merged 3 commits into from
Apr 2, 2021

Conversation

serut
Copy link
Contributor

@serut serut commented Apr 2, 2021

Motivation

When you set an invalid docId inside docusaurus.config.js, the error message that's thrown by DocNavbarItem does not let you know the list of existing docId.

Have you read the Contributing Guidelines on pull requests?

Yes.

Before

Screenshot from 2021-04-02 13-35-30

After

Screenshot from 2021-04-02 13-35-07

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 2, 2021
@netlify
Copy link

netlify bot commented Apr 2, 2021

@github-actions
Copy link

github-actions bot commented Apr 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 83
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4554--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Apr 2, 2021

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Apr 2, 2021
@slorber
Copy link
Collaborator

slorber commented Apr 2, 2021

thanks 👍

@slorber slorber merged commit 902aad5 into facebook:master Apr 2, 2021
@serut serut deleted the patch-1 branch April 6, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants