Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): theme default translations hindi #4596

Merged

Conversation

lisa761
Copy link
Contributor

@lisa761 lisa761 commented Apr 11, 2021

Motivation

Adding hindi translations for docusaurus.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

lisa761 and others added 7 commits February 15, 2021 19:39
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 11, 2021
@netlify
Copy link

netlify bot commented Apr 11, 2021

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost looks good, thanks

packages/docusaurus-theme-classic/codeTranslations/hi.json Outdated Show resolved Hide resolved
@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 69
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4596--docusaurus-2.netlify.app/

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Apr 12, 2021
@slorber slorber changed the title docs: theme default translations hindi feat(v2): theme default translations hindi Apr 12, 2021
@slorber
Copy link
Collaborator

slorber commented Apr 12, 2021

thanks :)

@slorber slorber merged commit 154ba62 into facebook:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants