fix(v2): use page title from config if not set #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Built with commit 2b479ea |
|
[V2] Built with commit 2b479ea |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4600--docusaurus-2.netlify.app/ |
|
Size Change: -50 B (0%) Total Size: 578 kB
ℹ️ View Unchanged
|
slorber
reviewed
Apr 12, 2021
|
|
||
| return ( | ||
| <Head> | ||
| {title && <title>{metaTitle}</title>} |
There was a problem hiding this comment.
oh I see, had a hard time figuring out what the problem was :D
|
LGTM thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4549
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try remove
titleprop fromLayoutcomponent of any page and make sure that title from config has been used.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)