Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): increase heading anchor offset #4601

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 11, 2021

Motivation

Resolves #4513

Slightly adding a little space for heading anchors to improve the design.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 11, 2021
@lex111 lex111 requested a review from slorber as a code owner April 11, 2021 23:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 11, 2021
@netlify
Copy link

netlify bot commented Apr 11, 2021

[V1]

Built with commit ecf19fd

https://deploy-preview-4601--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Apr 11, 2021

[V2]

Built with commit ecf19fd

https://deploy-preview-4601--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: +8 B (0%)

Total Size: 578 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB +8 B (0%)
website/build/assets/js/main.********.js 401 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 26.9 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Apr 12, 2021

👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2.0.0-alpha.72] Lack of space between headings and sticky nav bar
3 participants