Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase personal site evantay #4711

Merged
merged 2 commits into from
May 3, 2021

Conversation

DigiPie
Copy link
Contributor

@DigiPie DigiPie commented May 1, 2021

Motivation

I would like to showcase my personal open-source Docusaurus site on the official showcase.

Have you read the Contributing Guidelines on pull requests?

Yep, thanks for building this!

Test Plan

Tested locally:

image

Related PRs

N/A.

@facebook-github-bot
Copy link
Contributor

Hi @DigiPie!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented May 1, 2021

[V2]

Built with commit 995ed81

https://deploy-preview-4711--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented May 1, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4711--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 1, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 3, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 LGTM

website/src/data/users.js Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented May 3, 2021

[V1]

Built with commit 995ed81

https://deploy-preview-4711--docusaurus-1.netlify.app

@slorber slorber merged commit 3303543 into facebook:master May 3, 2021
@DigiPie DigiPie deleted the evan/showcase-evan branch May 4, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants