Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): delay i18n-staging deployment to avoid Crowdin 409 errors #4740

Merged
merged 1 commit into from
May 6, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 6, 2021

Motivation

Follow-up of #4739

Unfortunately, it did not work as the 2 deployments call the wait script at the exact same time.

Let's make prod deployment download Crowdin translations first, and then make i18n-staging wait until Crowdin can accept a new translation download

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label May 6, 2021
@slorber slorber requested a review from lex111 as a code owner May 6, 2021 16:35
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 6, 2021
@netlify
Copy link

netlify bot commented May 6, 2021

[V1]

Built with commit 52245bd

https://deploy-preview-4740--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented May 6, 2021

[V2]

Built with commit 52245bd

https://deploy-preview-4740--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented May 6, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4740--docusaurus-2.netlify.app/

@slorber slorber merged commit 83ce660 into master May 6, 2021
@github-actions
Copy link

github-actions bot commented May 6, 2021

Size Change: 0 B

Total Size: 691 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.5 kB 0 B
website/build/assets/js/main.********.js 513 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27.1 kB 0 B

compressed-size-action

@slorber slorber deleted the slorber/fix-crowdin-409-2 branch August 17, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants