refactor(v2): purify normalizeUrl #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V2] Built without sensitive environment variables with commit 7e680c0 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4814--docusaurus-2.netlify.app/ |
|
[V2] Built without sensitive environment variables with commit 7e680c0 |
slorber
added
the
pr: polish
|
Thanks, good catch. I don't really like those methods with unexpected side-effects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We use
normalizeUrla lot, and currently, there is no known issue. But it's always the best practice to use the pure function.I also add some code to keep the ts compiler silent in the test file. Please tell me if it's irrelevant, and I will remove it :)
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Review