Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix incorrect link to plugin-ideal-image #4896

Merged
merged 1 commit into from Jun 3, 2021
Merged

docs(v2): fix incorrect link to plugin-ideal-image #4896

merged 1 commit into from Jun 3, 2021

Conversation

phwt
Copy link
Contributor

@phwt phwt commented Jun 3, 2021

Motivation

Currently, it links to https://docusaurus.io/docs/using-plugins#docusaurusplugin-ideal-image which have no plugin-ideal-image related contents available (presumably moved)

To correctly guide users to the contents the link should be at https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-ideal-image

Have you read the Contributing Guidelines on pull requests?

Yes

@phwt phwt requested review from lex111 and slorber as code owners June 3, 2021 10:02
@facebook-github-bot
Copy link
Contributor

Hi @phwt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: a5143e4

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60b8a8c59535ec0008f41a30

😎 Browse the preview: https://deploy-preview-4896--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4896--docusaurus-2.netlify.app/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 3, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 3, 2021
@slorber
Copy link
Collaborator

slorber commented Jun 3, 2021

thanks ;)

@slorber slorber merged commit 0587d6d into facebook:master Jun 3, 2021
@slorber slorber changed the title Fix incorrect link to plugin-ideal-image docs(v2): fix incorrect link to plugin-ideal-image Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants