Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): bump react-waypoint from 9.0.2 to 10.1.0 #4915

Merged
merged 1 commit into from Jun 7, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 6, 2021

Motivation

Resolves #4913

Fixes following warning during @docusaurus/plugin-ideal-image installing:

  • npm WARN react-waypoint@9.0.3 requires a peer of react@^15.3.0 || ^16.0.0 but none is installed. You must install peer dependencies yourself.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

E2E test.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jun 6, 2021
@lex111 lex111 requested a review from slorber as a code owner June 6, 2021 06:47
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 6, 2021
@netlify
Copy link

netlify bot commented Jun 6, 2021

✔️ [V2]

🔨 Explore the source changes: 3287f40

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60bc6f92f9be500007ed9d1e

😎 Browse the preview: https://deploy-preview-4915--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 47
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 64

Lighthouse ran on https://deploy-preview-4915--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Jun 6, 2021

✔️ [V1]

🔨 Explore the source changes: 3287f40

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60bc6f92b21a090007f49679

😎 Browse the preview: https://deploy-preview-4915--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

Size Change: 0 B

Total Size: 621 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.3 kB 0 B
website/build/assets/js/main.********.js 443 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27.1 kB 0 B

compressed-size-action

@praveen4463
Copy link

@slorber Being this is a blocker, may I ask an estimated release date for this fix?

@slorber
Copy link
Collaborator

slorber commented Jun 7, 2021

LGTM thanks

@praveen4463 we have a @canary npm dist tag if you want to use the fix right now before the next release

@slorber slorber merged commit ce07640 into master Jun 7, 2021
@slorber slorber deleted the lex111/waypoint-bump branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React peer dependency error while installing plugin-ideal-image
4 participants