Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add archived versions system + archive alpha.73-75 #5005

Merged
merged 1 commit into from Jun 18, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 18, 2021

Motivation

We should be able to link to older doc versions, even if we don't keep their doc in the repo anymore.

This permits to reduce build times (particularly with i18n), but still let users access older docs

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jun 18, 2021
@slorber slorber requested a review from lex111 as a code owner June 18, 2021 15:15
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 18, 2021
@@ -0,0 +1,5 @@
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @lex111 if you archive a version you can get an immutable Netlify deployment link and add it there. I don't think it's needed to keep versions 3 months now, we can just add older versions this way in a more exhaustive way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice, thanks, maybe we can create [npm/bash] command to automate this? And why are URLs so long?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can create [npm/bash] command to automate this

Ideally, I'd like to have an official docusaurus archive CLI but that's not so simple due to the plugin system, multi-instance etc...

And why are URLs so long?

Those are the unique deploy URLs from Netlify. I don't think it's worth creating a custom subdomain DNS for all the older versions. I don't have direct access to the DNS config so it's a bit annoying to have to ask Joel on each archived release. Note also the React doc does this, some older docs redirect to an immutable vercel deployment: https://reactjs.org/versions

@netlify
Copy link

netlify bot commented Jun 18, 2021

✔️ [V2]

🔨 Explore the source changes: 7ecb59d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60ccb893eff1200007fd5931

😎 Browse the preview: https://deploy-preview-5005--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5005--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -85.3 kB (-13%) 👏

Total Size: 569 kB

Filename Size Change
website/build/assets/js/main.********.js 385 kB -89.7 kB (-19%) 👏
website/build/blog/2017/12/14/introducing-docusaurus/index.html 65.8 kB +2.19 kB (+3%)
website/build/index.html 30.5 kB +2.19 kB (+8%) 🔍
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.8 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B

compressed-size-action

@slorber slorber merged commit 871e090 into master Jun 18, 2021
@slorber slorber deleted the slorber/archived-site-versions branch August 17, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants