Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): less strict blog/docs uri frontmatter validation #5032

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 22, 2021

Motivation

After the beta.1 release, it has been reported that the new frontmatter validation is a bit too strict, in particular for URIs in blog post image/author URL. This makes the validation less strict, and allows paths like /x/y.png as before

#5011
#5012

Note: Joi is really painful to work with, in particular for the uri() type which cannot accept an absolute path, and does not make it easy at all to have clean error messages when building custom validation logic.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

tests

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 22, 2021
@slorber slorber requested a review from lex111 as a code owner June 22, 2021 08:29
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 22, 2021
@slorber slorber linked an issue Jun 22, 2021 that may be closed by this pull request
3 tasks
@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ [V2]

🔨 Explore the source changes: f553169

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d19f80213eff00078408cd

😎 Browse the preview: https://deploy-preview-5032--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5032--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 569 kB

ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 87.8 kB
website/build/assets/js/main.********.js 385 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 65.8 kB
website/build/docs/introduction/index.html 235 B
website/build/index.html 30.5 kB

compressed-size-action

@slorber slorber merged commit f20599b into master Jun 22, 2021
@dschaller
Copy link
Contributor

dschaller commented Jun 22, 2021

Thanks for the fix! Do you know when this will be released?

@slorber slorber deleted the slorber/fix-frontmatter-uri-validation branch August 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header URI validation fails on local resources
3 participants