Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix some docs container/sidebar layout issues #5035

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 22, 2021

Motivation

Fix some docs layout issues.

@CovalentBond reported here that the TOC should take more space for medium size devices (ex: 1300px): #4995 (comment)

image

Also fixing the collapsed sidebar icon appearing on mobile:

image

Also fixing the vertical scrollbar appearing for medium width when toc is large:

image

@lex111 any concern with those changes?

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 22, 2021
@slorber slorber requested a review from lex111 as a code owner June 22, 2021 13:41
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 22, 2021
@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ [V2]

🔨 Explore the source changes: f9fe66b

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d1e8822e8cbd0008358997

😎 Browse the preview: https://deploy-preview-5035--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5035--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -194 B (0%)

Total Size: 569 kB

Filename Size Change
website/build/assets/css/styles.********.css 87.6 kB -194 B (0%)
ℹ️ View Unchanged
Filename Size
website/build/assets/js/main.********.js 385 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 65.8 kB
website/build/docs/introduction/index.html 235 B
website/build/index.html 30.5 kB

compressed-size-action

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really better this way and it also reduce CSS code.

Also fixing the collapsed sidebar icon appearing on mobile

Strange, can't reproduce it, must be specific case?

@slorber
Copy link
Collaborator Author

slorber commented Jun 23, 2021

Strange, can't reproduce it, must be specific case?

Edge case: you have to collapse the navbar and then reduce your viewport size. Not very likely to happen in practice

@slorber slorber merged commit 7e55aa1 into master Jun 23, 2021
@slorber slorber deleted the slorber/remove-docItemWrapper-maxWidth branch August 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants