fix(v2): Fix announcementBar layout shifts #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 70059ab 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d34b8e6fb6790008af804d 😎 Browse the preview: https://deploy-preview-5040--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5040--docusaurus-2.netlify.app/ |
|
Size Change: +1.96 kB (0%) Total Size: 571 kB
ℹ️ View Unchanged
|
|
It also decides bug with height adjustment of sidebar menu. Apparently this regression after #4617 (just now noticed it).
|
|
Thanks
What do you mean by "decides bug"? is this fixed? |
|
Yes, this PR fixes that bug. |
|
great news then :) thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Docusaurus announcement bar is appearing only after React hydration
It triggers a layout shift, which is a bad signal for SEO / Google / Core Web Vitals (cumulative layout shift metric)
Instead we can render the announcement bar on the server, and hide it immediately with inlined js if it has been dismissed
This removes completely the layout shift issue in core web vitals extension:
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview