fix(v2): read last update from inner git repositories #5048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
My use case:
With the current implementation, the
lastUpdate
won't return any data, as the files are unknown by Git when usingwebsite
as thecwd
. But if we call git in their own folders, git will be able to properly read the metadata.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I verified by replacing the content of
lastUpdate.js
in mynode_modules
folder, which worked. But if needed, I can find a way to record a video. I just didn't record yet because in my tests there are private data from my company.The good news is that this change won't break any existing use case, it will just fix mine.
Related PRs
None