-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Rewrite markdown images section #5064
Conversation
Before it looked like we have two ways to display images, now it's three ways. Each syntax has a separate example. This way it's clear, I see each method and the code example. Before there were 2 methods in a single code block.
✔️ [V2] 🔨 Explore the source changes: f51afc3 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60dc46e8882c400008f2b34f 😎 Browse the preview: https://deploy-preview-5064--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5064--docusaurus-2.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting some text changes for consistency
website/docs/guides/markdown-features/markdown-features-assets.mdx
Outdated
Show resolved
Hide resolved
website/docs/guides/markdown-features/markdown-features-assets.mdx
Outdated
Show resolved
Hide resolved
website/docs/guides/markdown-features/markdown-features-assets.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
@slorber thank you for the text changes! |
Before it looked like we have two ways to display images, now it's three ways. Each syntax has a separate example.
This way it's clear, I see each method and the code example.
Before there were 2 methods in a single code block.