Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add SQL Frames to the showcase #5086

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Conversation

dirslashls
Copy link
Contributor

SQL Frames product documentation is brought live using Docusaurus.

SQL Frames is a DataFrames technology that works completely within the browser by composing the logic using SQL constructs. Since Docusaurus allows embedding react components within the documentation, it is a perfect way to create documentation for SQL Frames using live embedded examples within the documentation, tutorial and blog posts!

@facebook-github-bot
Copy link
Contributor

Hi @dirslashls!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@dirslashls dirslashls marked this pull request as draft June 29, 2021 18:54
@netlify
Copy link

netlify bot commented Jun 29, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 14f23bf

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60db7e6af5e6c90007fae943

😎 Browse the preview: https://deploy-preview-5086--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5086--docusaurus-2.netlify.app/

@dirslashls dirslashls marked this pull request as ready for review June 29, 2021 20:25
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 29, 2021
@slorber slorber changed the title Add SQL Frames to the showcase docs(v2): Add SQL Frames to the showcase Jun 30, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 30, 2021
@slorber
Copy link
Collaborator

slorber commented Jun 30, 2021

Thanks 👍 cool usage of MDX

@slorber slorber merged commit b499331 into facebook:master Jun 30, 2021
@dirslashls dirslashls deleted the patch-1 branch June 30, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants