fix(v2): redirect from should work with trailingSlash: true #5093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 852e179 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60dc2cb24e073f000876bfed 😎 Browse the preview: https://deploy-preview-5093--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5093--docusaurus-2.netlify.app/ |
5 tasks
|
Size Change: 0 B Total Size: 601 kB ℹ️ View Unchanged
|
slorber
deleted the
slorber/redirect-from-should-work-with-trailing-slash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up of #5055 (comment)
When using
trailingSlash: true, the redirect plugin does not emit files forfromExtensions: ['html']because it ignorers all paths ending with/If there's a path such as
/xyz/, we should emit/xyz.html/index.html, otherwise deployments like Netlify wouldn't redirect when browsing/xyz.html, they would just serve the HTML file and it would lead to a 404 error due to the route not existing on the frontend router.Also cleanup now useless warning since we reverted to emit
/xyz.html/index.html, as the warning does not make sense anymoreHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
test + preview
This URL now works fine, while it used to display a frontend 404 error: https://deploy-preview-5093--docusaurus-2.netlify.app/docs/typescript-support.html
Related PRs
#5085