Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix iframe background color in dark mode #5223

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jul 27, 2021

Motivation

It turns out that using color-scheme can lead to incorrect backgrounds in iframes on dark scheme. At least on our site:

image

image

Not sure if we should globally assign color-scheme to auto to avoid this issues on our client sites?

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

image

image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner July 27, 2021 12:08
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 27, 2021
@lex111 lex111 changed the title chore: fix GH button background color in dark mode chore: fix iframe background color in dark mode Jul 27, 2021
@netlify
Copy link

netlify bot commented Jul 27, 2021

✔️ [V2]

🔨 Explore the source changes: 9a83428

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60fff734d3aa9f00077057ae

😎 Browse the preview: https://deploy-preview-5223--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5223--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +30 B (0%)

Total Size: 856 kB

Filename Size Change
website/build/assets/css/styles.********.css 92 kB +36 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 59.2 kB 0 B
website/build/assets/js/main.********.js 461 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.4 kB 0 B
website/build/blog/index.html 26.4 kB 0 B
website/build/docs/index.html 40.3 kB -3 B (0%)
website/build/docs/installation/index.html 47.9 kB -3 B (0%)
website/build/index.html 27.3 kB 0 B
website/build/tests/docs/index.html 20.9 kB 0 B
website/build/tests/docs/standalone/index.html 18.8 kB 0 B

compressed-size-action

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 27, 2021
@slorber
Copy link
Collaborator

slorber commented Jul 27, 2021

thanks

this is a bit weird, surprised by this behavior 😅

Not sure if we should globally assign color-scheme to auto to avoid these issues on our client sites?

yeah applying this for all iframes in Infima can make sense, maybe we'll see according to user feedbacks after the release?

@slorber slorber merged commit 7e48961 into master Jul 27, 2021
@lex111
Copy link
Contributor Author

lex111 commented Jul 27, 2021

yeah applying this for all iframes in Infima can make sense, maybe we'll see according to user feedbacks after the release?

Yes, I think it's safe to do for all iframes. Perhaps our users who used iframes also like us until today did not know about this small BC.

@lex111 lex111 deleted the lex111/iframe-home branch July 27, 2021 14:59
slorber added a commit to facebookincubator/infima that referenced this pull request Jul 28, 2021
slorber added a commit to facebookincubator/infima that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants