-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix iframe background color in dark mode #5223
Conversation
✔️ [V2] 🔨 Explore the source changes: 9a83428 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60fff734d3aa9f00077057ae 😎 Browse the preview: https://deploy-preview-5223--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5223--docusaurus-2.netlify.app/ |
Size Change: +30 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
thanks this is a bit weird, surprised by this behavior 😅
yeah applying this for all iframes in Infima can make sense, maybe we'll see according to user feedbacks after the release? |
Yes, I think it's safe to do for all iframes. Perhaps our users who used iframes also like us until today did not know about this small BC. |
Motivation
It turns out that using
color-scheme
can lead to incorrect backgrounds in iframes on dark scheme. At least on our site:Not sure if we should globally assign
color-scheme
toauto
to avoid this issues on our client sites?Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)