Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve spanish translation #5275

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

faloi
Copy link
Contributor

@faloi faloi commented Aug 3, 2021

Motivation

I'm a spanish native speaker and I found some diacritic errors when using the current translation. Also, I've translated some values that were in english.

Have you read the Contributing Guidelines on pull requests?

Yes.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 3, 2021
@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 693626e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61094901ba4ca90007c22772

😎 Browse the preview: https://deploy-preview-5275--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5275--docusaurus-2.netlify.app/

@faloi
Copy link
Contributor Author

faloi commented Aug 3, 2021

Just to clarify my change proposal: esta and está may seem pretty similar, but their meanings are completely different:

With tilde, is a form of the verb to be:
🇪🇸 El gato está debajo de la mesa.
🇺🇸 The cat is under the table.

Without it, it's a pronoun:
🇪🇸 Editar esta página.
🇺🇸 Edit this page.

@lex111 lex111 merged commit 22d3299 into facebook:master Aug 3, 2021
@lex111
Copy link
Contributor

lex111 commented Aug 3, 2021

@faloi thanks!

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Aug 3, 2021
@faloi faloi deleted the fix-improve-spanish-translation branch August 3, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants