-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: blog posts support /YYYY/MM/DD/blog-post/index.md pattern + blog frontmatter can reference relative images #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urceFile in separate method
✔️ [V2] 🔨 Explore the source changes: 031c2ef 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/610d533fe5a91a000810e4af 😎 Browse the preview: https://deploy-preview-5309--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5309--docusaurus-2.netlify.app/ |
Size Change: +5.33 kB (+1%) Total Size: 792 kB
ℹ️ View Unchanged
|
Josh-Cena
reviewed
Aug 6, 2021
…sets, converted to Webpack require calls and exposed as frontMatterAssets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Blog posts generally have assets such as images.
It makes sense to create a folder for a blog post and co-locate all images related to the blog post in its folder.
Example:
2021-05-12-announcing-docusaurus-two-beta/index.md
or2021/05/12/announcing-docusaurus-two-beta/index.md
See also: #5301
This PR makes:
The following will now be supported and paths will be converted to Webpack file-loader require calls:
Also:
frontMatterAssets
exportHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
tests + dogfooding on our own blog
Blog posts keep the same URL:
Social card + author img keeps working
The little blog page size increase is expected: it's the url-loader inlining a small image as base64 in the HTML file