fix: make proper highlighting doc link if no sidebar #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close All navbar items without sidebar are active facebook#5310
|
✔️ [V2] 🔨 Explore the source changes: c113b0c 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/610ef6e9e2a8670008358b62 😎 Browse the preview: https://deploy-preview-5317--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5317--docusaurus-2.netlify.app/ |
lex111
reviewed
Aug 7, 2021
packages/docusaurus-theme-classic/src/theme/NavbarItem/DocNavbarItem.tsx
Outdated
Show resolved
Hide resolved
lex111
changed the title
…arItem.tsx Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
lex111
approved these changes
Aug 8, 2021
fantua
reviewed
Aug 8, 2021
| @@ -56,7 +56,7 @@ export default function DocNavbarItem({ | |||
| {...props} | |||
| className={clsx(props.className, { | |||
| [activeDocInfimaClassName]: | |||
| activeDoc && activeDoc.sidebar === doc.sidebar, | |||
| activeDoc?.sidebar && activeDoc.sidebar === doc.sidebar, | |||
There was a problem hiding this comment.
in this case navbar items without sidebar always will be inactive?
There was a problem hiding this comment.
No it would work fine because it's already the default behavior for a link to be active when we are on the link target page. We only need this additional class to enable the "tab-like" behavior.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5310
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)