Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin ideal-image should generate filename with a hash even in development #5334

Conversation

Pierre-Gilles
Copy link
Contributor

Hi! Following our discussion here (#5326), I wrote a PR to generate hash filename even in dev environnement.

I've run the test suites, linter & prettier and it seems fine. I've started the Docusaurus website locally as well.

I haven't found any tests for this plugin so I don't know if I should write some?

Have you read the Contributing Guidelines on pull requests?

Yes

@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 4d59a85

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61133bc5b0eb1b000757ecdd

😎 Browse the preview: https://deploy-preview-5334--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5334--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Aug 11, 2021

Thanks 👍

I haven't found any tests for this plugin so I don't know if I should write some?

Not sure there's a good way to unit test this anyway. We have some e2e test that fails if yarn start has webpack errors/warnings in our own website so the best test could be to dogfood your use-case and add 2 images of the same name to our website. Not sure it's really worth it.

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 11, 2021
@slorber slorber changed the title Fix #5326: Plugin ideal-image should generate filename with a hash even in development fix: plugin ideal-image should generate filename with a hash even in development Aug 11, 2021
@slorber slorber merged commit ec1401a into facebook:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants