refactor(plugin-blog): style improvements in blogUtils #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Josh-Cena
commented
Aug 11, 2021
Comment on lines
+199
to
+200
| // Fallback to file create time | ||
| return (await fs.stat(blogSourceAbsolute)).birthtime; |
There was a problem hiding this comment.
Just a personal taste here, pretending we have no-else-return enabled
|
✔️ [V2] 🔨 Explore the source changes: 36f929a 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6113a18a82b5cf0007a674ab 😎 Browse the preview: https://deploy-preview-5338--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5338--docusaurus-2.netlify.app/ |
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Josh-Cena
changed the title
|
👍 thanks |
slorber
added
pr: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ESLint caught some useless escapes in the regex. I take this opportunity to also make the code more stylistically sound.
Have you read the Contributing Guidelines on pull requests?
Yep