fix: add admonitions support to mdx partials loaded through the fallback mdx loader #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 9d3f740 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6113dc99faed620008d4256d 😎 Browse the preview: https://deploy-preview-5339--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5339--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 793 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #5333
Note it's a good-enough solution but not ideal because the admonition config is static and can't be disabled (unlike content plugins): we'll expose a global way to configure markdown/mdx for the whole docusaurus site later
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Not automated but works locally on the changelog page: