Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: author/image adjustments in BlogPosting schema #5346

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Aug 11, 2021

Motivation

Just small fixes in BlogPosting schema after merge #5322:

  • Use author name instead of its title
  • Use absolute URL for image instead of relative one

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

Results for blog/2021/05/12/announcing-docusaurus-two-beta:

- {"@context":"https://schema.org","@type":"BlogPosting","headline":"Announcing Docusaurus 2 Beta","description":"After a lengthy alpha stage in order to ensure feature parity and quality, we are excited to officially release the first Docusaurus 2 beta.","image":["/assets/images/social-card-414bbe5147ecc177bbe8d858616709c5.png"],"datePublished":"2021-05-12T00:00:00.000Z","author":{"@type":"Person","name":"Docusaurus maintainer","url":"https://sebastienlorber.com"}}
+ {"@context":"https://schema.org","@type":"BlogPosting","headline":"Announcing Docusaurus 2 Beta","description":"After a lengthy alpha stage in order to ensure feature parity and quality, we are excited to officially release the first Docusaurus 2 beta.","image":["https://docusaurus.io/assets/images/social-card-414bbe5147ecc177bbe8d858616709c5.png"],"datePublished":"2021-05-12T00:00:00.000Z","author":{"@type":"Person","name":"Sébastien Lorber","url":"https://sebastienlorber.com"}}

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Aug 11, 2021
@lex111 lex111 requested a review from slorber as a code owner August 11, 2021 23:58
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 11, 2021
@netlify
Copy link

netlify bot commented Aug 12, 2021

✔️ [V2]

🔨 Explore the source changes: 0de9a31

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61146421838a110008bbd9d2

😎 Browse the preview: https://deploy-preview-5346--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5346--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +15 B (0%)

Total Size: 793 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.2 kB 0 B
website/build/assets/css/styles.********.css 93.1 kB 0 B
website/build/assets/js/main.********.js 403 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 64.2 kB +21 B (0%)
website/build/blog/index.html 33.1 kB 0 B
website/build/docs/index.html 41.9 kB -3 B (0%)
website/build/docs/installation/index.html 49.6 kB -3 B (0%)
website/build/index.html 28.7 kB 0 B
website/build/tests/docs/index.html 22.5 kB 0 B
website/build/tests/docs/standalone/index.html 20.5 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Aug 12, 2021

👍 thanks

@slorber slorber merged commit cbff487 into master Aug 12, 2021
@slorber slorber deleted the lex111/blog-scheme-fixes branch August 12, 2021 13:10
@lex111
Copy link
Contributor Author

lex111 commented Aug 12, 2021

@slorber just found out, we can annotate existent HTML markup to following BlogPosting schema, then we won't need to use JSON-LD. What do you think of this? https://orbitingweb.com/blog/schema-org-microdata-guide/

@slorber
Copy link
Collaborator

slorber commented Aug 12, 2021

This might make the structured data more maintainable and avoid using duplicate conditional logic?

Not sure we have this case on the blog posts, but how does it work when 2 structured data entities markup get interleaved in the HTML markup?

Does it lead to the exact same SEO outcome?

That's worth attempting a refactor

@johnnyreilly any opinion?

@lex111
Copy link
Contributor Author

lex111 commented Aug 12, 2021

Not sure we have this case on the blog posts, but how does it work when 2 structured data entities markup get interleaved in the HTML markup?

There shouldn't be a problem with this, since there is microdata for blog lists.

This might make the structured data more maintainable and avoid using duplicate conditional logic?
Does it lead to the exact same SEO outcome?

Yes, and moreover we get rid of duplicated data in separated comp. I'll see to this, maybe it will work out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants