Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mdx-loader): migrate package to TypeScript #5347

Merged
merged 8 commits into from
Aug 12, 2021
Merged

chore(mdx-loader): migrate package to TypeScript #5347

merged 8 commits into from
Aug 12, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Following discussion with @slorber, migrated mdx-loader to TS for better type checks and hints.

Have you read the Contributing Guidelines on pull requests?

Yea

Test Plan

Unit tests

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 12, 2021
@netlify
Copy link

netlify bot commented Aug 12, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 969b45c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6114af39a1dce40008e83f85

😎 Browse the preview: https://deploy-preview-5347--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 12, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5347--docusaurus-2.netlify.app/

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5347--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Aug 12, 2021 •
edited
Loading

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 7bf3766

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611504c56dac1a00072be541

😎 Browse the preview: https://deploy-preview-5347--docusaurus-2.netlify.app

@Josh-Cena
Polish code style
1b41eff 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
Partly done migration
c132981 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
Complete typing
b598001 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
Fix tests
a528f3a 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
A-ha
cc53c26 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
Cleanup
0131af8 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
Fix error
2c29d4c 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
Cleanup
7bf3766 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Aug 12, 2021
@slorber
Copy link
Collaborator

slorber commented Aug 12, 2021

Thanks, LGTM

@slorber slorber merged commit 3fc4793 into facebook:master Aug 12, 2021
@Josh-Cena Josh-Cena deleted the mdx-loader-ts branch August 12, 2021 12:56
@Josh-Cena Josh-Cena mentioned this pull request Oct 29, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@slorber slorber Awaiting requested review from slorber

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Josh-Cena @slorber @facebook-github-bot