Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docusaurus-plugin-sass instructions #5352

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

erickzhao
Copy link
Contributor

Motivation

The docusaurus-plugin-sass plugin has sass as a peer dependency, so you
need to install that package as well, as per their README.

Have you read the Contributing Guidelines on pull requests?

Yes!

Test Plan

N/A (docs change)

Related PRs

N/A

The `docusaurus-plugin-sass` plugin has `sass` as a peer dependency, so you
need to install that package as well, as per their README.
@facebook-github-bot
Copy link
Contributor

Hi @erickzhao!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Aug 12, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: d2d5833

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61157348f51023000866c4b4

😎 Browse the preview: https://deploy-preview-5352--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5352--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 12, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber
Copy link
Collaborator

slorber commented Aug 13, 2021

thanks 👍

@slorber slorber merged commit c76dfb8 into facebook:master Aug 13, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 13, 2021
@erickzhao erickzhao deleted the patch-1 branch August 13, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants