Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): improved Farsi default translations #5365

Merged
merged 2 commits into from
Aug 15, 2021
Merged

refactor(v2): improved Farsi default translations #5365

merged 2 commits into from
Aug 15, 2021

Conversation

massoudmaboudi
Copy link
Contributor

Motivation

Improved default Farsi translations for the classic theme.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/ is rendered properly.

Related PRs

No

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 15, 2021
@netlify
Copy link

netlify bot commented Aug 15, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 8040de2

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6119658f12513e0008d449f3

😎 Browse the preview: https://deploy-preview-5365--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5365--docusaurus-2.netlify.app/

@lex111 lex111 merged commit 7b807fd into facebook:master Aug 15, 2021
@lex111
Copy link
Contributor

lex111 commented Aug 15, 2021

@massoudmaboudi seems good, thanks!

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants