Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean Canny integration + rename 'Feedback' to 'Feature Requests' + improve TS doc page #5389

Merged
merged 5 commits into from
Aug 20, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 19, 2021

Motivation

The existing Canny integration was a bit weird, as it used the 404 pages and redirected some subpaths to the canny board

We should be able to handle client-side routes better (not serving them with status 404) by using a simple CDN proxy config (widely available, except GitHub Pages...)

This is also an initial proof of concept showing that this is technically possible to do this correctly.

Later I'd like to document how to add client-side authenticated routes to a Docusaurus site, and maybe build a plugin for that.

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

preview

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Aug 19, 2021
@slorber slorber requested a review from lex111 as a code owner August 19, 2021 18:04
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 19, 2021
@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ [V2]

🔨 Explore the source changes: 6d55c10

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611f753046dcb80007070aa5

😎 Browse the preview: https://deploy-preview-5389--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 19, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5389--docusaurus-2.netlify.app/

@slorber slorber marked this pull request as draft August 19, 2021 18:11
@github-actions
Copy link

github-actions bot commented Aug 19, 2021

Size Change: +209 B (0%)

Total Size: 810 kB

Filename Size Change
website/build/assets/js/main.********.js 410 kB +68 B (0%)
website/build/docs/index.html 43.1 kB +43 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.2 kB 0 B
website/build/assets/css/styles.********.css 93.7 kB +3 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 65.3 kB +16 B (0%)
website/build/blog/index.html 35.4 kB +16 B (0%)
website/build/docs/installation/index.html 50.7 kB +15 B (0%)
website/build/index.html 29.8 kB +16 B (0%)
website/build/tests/docs/index.html 23.9 kB +16 B (0%)
website/build/tests/docs/standalone/index.html 21.8 kB +16 B (0%)

compressed-size-action

@slorber slorber changed the title refactor: clean Canny integration + rename 'Feedback' to 'Feature Requests' refactor: clean Canny integration + rename 'Feedback' to 'Feature Requests' + improve TS doc page Aug 20, 2021
@slorber slorber marked this pull request as ready for review August 20, 2021 09:13
@slorber slorber merged commit f40ce05 into main Aug 20, 2021
@slorber slorber deleted the slorber/fix-site-canny-board branch August 20, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants