Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename docusaurus-2-website package + refactor scripts #5397

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 20, 2021

Motivation

Since we don't have Docusaurus v1 in main some script/package name do not make too much sense anymore

Let's rename those.

It's easier to type yarn workspace website than yarn workspace docusaurus-2-website

It's more explicit to run yarn start:website than yarn start:v2

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

ci

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Aug 20, 2021
@slorber slorber requested a review from lex111 as a code owner August 20, 2021 15:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 20, 2021
@netlify
Copy link

netlify bot commented Aug 20, 2021

✔️ [V2]

🔨 Explore the source changes: e2751ce

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611fcb94d215be0008443f4f

😎 Browse the preview: https://deploy-preview-5397--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 96
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5397--docusaurus-2.netlify.app/

@slorber slorber merged commit 631c468 into main Aug 20, 2021
@slorber slorber deleted the slorber/rename-docusaurus-2-website-package branch August 20, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants