feat: Add docs-related stable classnames #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 73dfc33 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/612d1be46102f700088c0a8f 😎 Browse the preview: https://deploy-preview-5445--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5445--docusaurus-2.netlify.app/ |
|
Size Change: +1.84 kB (0%) Total Size: 820 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Start introducing some stable theme class names so that users can more easily target some components to customize with custom CSS selectors, ensuring those selectors don't break over time.
For now, we are just introducing some initial classNames, covering needs of the React-Native website, and we don't document this feature on purpose, so breaking changes can still happen.
If successful, we'll generalize and document this, and commit to avoid any undocumented breaking change.
Going to merge this now as I need it to make RN website more resilient, but feel free to comment if you have better ideas, naming convention, or whatever.
``
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview