refactor: use SVG for closable button in announcement bar #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: polish
|
✔️ [V2] 🔨 Explore the source changes: e102399 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/612ddfba92dceb000794641a 😎 Browse the preview: https://deploy-preview-5453--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5453--docusaurus-2.netlify.app/ |
|
Size Change: +1.18 kB (0%) Total Size: 820 kB
ℹ️ View Unchanged
|
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The vertical centering of Unicode character is unstable, for example in Chrome on Linux, alignment of "x" char looks more or less ok, but in Chrome on Windows, it is much worse:
That's why I suggest using SVG icon to achieve uniform alignment in all browsers.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)