Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docusaurus-plugin-relative-paths #5471

Merged
merged 1 commit into from
Sep 2, 2021
Merged

docs: Add docusaurus-plugin-relative-paths #5471

merged 1 commit into from
Sep 2, 2021

Conversation

ohkimur
Copy link
Contributor

@ohkimur ohkimur commented Sep 2, 2021

Motivation

Just adding docusaurus-plugin-relative-paths to the unofficial plugins list.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Only md update.

Related PRs

No PR's are related. However, here is the issue that started everything. 😅

@facebook-github-bot
Copy link
Contributor

Hi @ohkimur!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 177b2ae

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6130df0bcf058600079fc3bb

😎 Browse the preview: https://deploy-preview-5471--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5471--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 2, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber changed the title Add docusaurus-plugin-relative-paths docs: Add docusaurus-plugin-relative-paths Sep 2, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 2, 2021
@slorber
Copy link
Collaborator

slorber commented Sep 2, 2021

Thanks 👍

@slorber slorber merged commit e5d9ff1 into facebook:main Sep 2, 2021
@slorber
Copy link
Collaborator

slorber commented Sep 2, 2021

Note: I find this plugin's name/description is a bit confusing. It may be useful to explain why in the first place someone wants to convert absolute paths to relative paths, and ideally the plugin name should reflect the intended usecase / problem solved

@ohkimur ohkimur deleted the patch-1 branch September 2, 2021 17:28
@ohkimur
Copy link
Contributor Author

ohkimur commented Sep 2, 2021

@slorber I tried to follow the general name pattern that I see with other Docusaurus plugins. 😔 I made a small update to the repo update. I hope this will help other people understand the purpose of the plugin a little bit easier. If you have some suggestions I am open to ideas. ✌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants