fix: use heading itself as anchor for better crawling #5481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #5470
We have anchor link for headings without
href
attribute, which causes warning from Lighthouse https://developers.google.com/search/docs/advanced/guidelines/links-crawlableBut since we already use new
scroll-margin-top
, we can remove separate element for heading anchor, and instead just add this property on heading tag itself.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview + Lighthouse report
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)