Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention Netlify ignore build setting #5486

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 3, 2021

Motivation

Add some useful doc for v1 sites that upgraded and using Netlify, as it affected some FB Docusaurus sites

image

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 3, 2021
@slorber slorber requested a review from lex111 as a code owner September 3, 2021 17:17
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 3, 2021
@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ [V2]

🔨 Explore the source changes: 3a7cb12

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6132588daea0e80007c71c99

😎 Browse the preview: https://deploy-preview-5486--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5486--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Size Change: 0 B

Total Size: 826 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 36.7 kB
website/build/assets/css/styles.********.css 93.9 kB
website/build/assets/js/main.********.js 414 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB
website/build/blog/index.html 38.1 kB
website/build/docs/index.html 44.6 kB
website/build/docs/installation/index.html 52.8 kB
website/build/index.html 30.8 kB
website/build/tests/docs/index.html 25.4 kB
website/build/tests/docs/standalone/index.html 23 kB

compressed-size-action

@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ [V2]

🔨 Explore the source changes: 09ae0d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/613258e84e8a0f0008bd962c

😎 Browse the preview: https://deploy-preview-5486--docusaurus-2.netlify.app

@slorber slorber merged commit 4f59f07 into main Sep 3, 2021
@slorber slorber deleted the slorber/netlify-ignore-doc branch September 3, 2021 17:34
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved even after the merge 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants