Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code example #5566

Merged
merged 1 commit into from
Sep 15, 2021
Merged

docs: fix code example #5566

merged 1 commit into from
Sep 15, 2021

Conversation

ChrisChinchilla
Copy link
Contributor

Motivation

As far as I could tell, the page you are told to edit is incorrect, so updated the parts to what I think is correct

@netlify
Copy link

netlify bot commented Sep 13, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 9c3509a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/613f6f0eecaaf000072a1917

😎 Browse the preview: https://deploy-preview-5566--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5566--docusaurus-2.netlify.app/

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 15, 2021
@lex111 lex111 changed the title Update creating-pages.md docs: fix code example Sep 15, 2021
@lex111 lex111 merged commit beedadd into facebook:main Sep 15, 2021
@lex111
Copy link
Contributor

lex111 commented Sep 15, 2021

@ChrisChinchilla thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants