Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight active item in recent post list #5571

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Sep 15, 2021

Motivation

Fixes #5563

Because we use restructureRules option in clean-css, active item in a latest blog posts block on blog pages is not highlighted.

This bug is not reproduced on Docusaurus site because we have similar CSS selectors with the same declaration (color: var(--ifm-color-primary)), so we haven't noticed it.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Sep 15, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 15, 2021
@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ [V2]

🔨 Explore the source changes: bbcc3d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61421314e288210008b6450c

😎 Browse the preview: https://deploy-preview-5571--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5571--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +37 B (0%)

Total Size: 826 kB

Filename Size Change
website/build/assets/css/styles.********.css 94.1 kB +41 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.7 kB 0 B
website/build/assets/js/main.********.js 414 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB 0 B
website/build/blog/index.html 38.1 kB 0 B
website/build/docs/index.html 44.5 kB -2 B (0%)
website/build/docs/installation/index.html 52.8 kB -2 B (0%)
website/build/index.html 30.8 kB 0 B
website/build/tests/docs/index.html 25.4 kB 0 B
website/build/tests/docs/standalone/index.html 23 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Sep 21, 2021

Thanks

Hope that this restructure optimization won't cause other problems like this, not too fan of using important

@slorber slorber merged commit 911d6b1 into main Sep 21, 2021
@slorber slorber deleted the lex111/iss5563 branch September 21, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog sidebar active item is not highlighted
3 participants