Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): type improvements for PendingNavigation #5580

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Sep 17, 2021

Motivation

Fix a few any types.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 17, 2021
@netlify
Copy link

netlify bot commented Sep 17, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 032ba10

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61471aa1a9c86d0008b8b13e

😎 Browse the preview: https://deploy-preview-5580--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 17, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5580--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title polish: type improvements for PendingNavigation polish(core): type improvements for PendingNavigation Sep 17, 2021
@Josh-Cena Josh-Cena marked this pull request as ready for review September 19, 2021 11:01
@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Sep 21, 2021
@lex111 lex111 changed the title polish(core): type improvements for PendingNavigation refactor(core): type improvements for PendingNavigation Sep 21, 2021
@lex111 lex111 merged commit e0aa87f into facebook:main Sep 21, 2021
@lex111
Copy link
Contributor

lex111 commented Sep 21, 2021

@Josh-Cena thanks!

@Josh-Cena Josh-Cena deleted the type-Location branch September 21, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants