Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): document npm2yarn plugin + use new Tabs API everywhere #5590

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Sep 19, 2021

Motivation

Since the new tabs API is probably less verbose, let's make it the encouraged behavior by using it everywhere.

Also documented the npm2yarn as a multi-language possibility, so that we can safely remove the <MultiLanguageCode /> hint, since IMO we have already provided the right level of abstraction.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 19, 2021
@netlify
Copy link

netlify bot commented Sep 19, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 632e95c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6147dda5e930d700089ec4f3

😎 Browse the preview: https://deploy-preview-5590--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 19, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5590--docusaurus-2.netlify.app/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 22, 2021
@slorber
Copy link
Collaborator

slorber commented Sep 22, 2021

LGTM 👍

@slorber slorber merged commit 89cb975 into facebook:main Sep 22, 2021
@Josh-Cena Josh-Cena deleted the npm2yarn-doc branch September 22, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants