refactor(core): enforce noImplicitAny #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
|
✔️ [V2] 🔨 Explore the source changes: 051d853 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/614b3aae0c1e7700087f1ae7 😎 Browse the preview: https://deploy-preview-5605--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5605--docusaurus-2.netlify.app/ |
slorber
added
the
pr: maintenance
|
Thanks, LGTM 👍 Maybe we could avoid the comment for errors? but this is good enough to merge |
|
We should definitely figure out why there's type inconsistencies, and maybe downgrade our typing packages / upgrade our webpack plugin dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixed quite a few implicit anys. There are temporary patches, though, because I'm not entirely sure whether the type incompatibility was due to an uncaught API change or just because we are using an outdated package (I do notice
@ts-expect-errorin multiple places in core though)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI