Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): create tags route if only tags exists #5606

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Sep 22, 2021

Motivation

Just fixes #5599.

Have you read the Contributing Guidelines on pull requests?

Resolves

Test Plan

Preview (since we don't use tags, /tags should return 404 error)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Sep 22, 2021
@netlify
Copy link

netlify bot commented Sep 22, 2021

✔️ [V2]

🔨 Explore the source changes: 3d77a84

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/614b8e7c6e23c00007c87fdd

😎 Browse the preview: https://deploy-preview-5606--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 22, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5606--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Sep 22, 2021

Size Change: -999 B (0%)

Total Size: 824 kB

Filename Size Change
website/build/assets/js/main.********.js 413 kB -995 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.7 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB 0 B
website/build/blog/index.html 38 kB 0 B
website/build/docs/index.html 44.5 kB -2 B (0%)
website/build/docs/installation/index.html 52.7 kB -2 B (0%)
website/build/index.html 30.8 kB 0 B
website/build/tests/docs/index.html 25.3 kB 0 B
website/build/tests/docs/standalone/index.html 22.9 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Sep 22, 2021

✔️ [V2]

🔨 Explore the source changes: fa17071

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/614b8ffc151d1600083525aa

😎 Browse the preview: https://deploy-preview-5606--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Sep 23, 2021

LGTM thanks 👍

@slorber slorber merged commit e66e045 into main Sep 23, 2021
@slorber slorber deleted the lex111/iss5599 branch September 23, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On build, docusaurus creates a "Tags" page
3 participants