Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix warning after build #5628

Merged
merged 1 commit into from
Sep 30, 2021
Merged

chore: fix warning after build #5628

merged 1 commit into from
Sep 30, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Sep 29, 2021

Motivation

Currently, on changelog page there is a false call JSX-component ColorGenerator, which causes warning after building of site, and renders empty div instead text.

Component ColorGenerator was not imported, exported, or provided by MDXProvider as global scope

image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Sep 29, 2021
@netlify
Copy link

netlify bot commented Sep 29, 2021

✔️ [V2]

🔨 Explore the source changes: 6e5307c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6154eb38b6c3540007188e13

😎 Browse the preview: https://deploy-preview-5628--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5628--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -4 B (0%)

Total Size: 835 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.5 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/assets/js/main.********.js 421 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB 0 B
website/build/blog/index.html 38 kB 0 B
website/build/docs/index.html 44.7 kB -2 B (0%)
website/build/docs/installation/index.html 52.8 kB -2 B (0%)
website/build/index.html 30.8 kB 0 B
website/build/tests/docs/index.html 25.5 kB 0 B
website/build/tests/docs/standalone/index.html 22.9 kB 0 B

compressed-size-action

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 29, 2021
@slorber
Copy link
Collaborator

slorber commented Sep 30, 2021

👍 yes I've fixed some other parts of the changelog for mdx compact but missed this one thanks

@slorber slorber merged commit 725e7e3 into main Sep 30, 2021
@slorber slorber deleted the lex111-patch-1 branch September 30, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants