Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix long-standing React hydration problem on text with links where links end-up with the wrong href after React hydration, due to mismatch between SSR HTML and client hydration.
Issue #5617
(Also seen on React-Native and/or websites in the past)
Using
html-minifier-terser
removeComments: true
is causing this hydration problem by turning this React SSR output:into this:
Dan Abramov confirms those comments are necessary: https://twitter.com/dan_abramov/status/1443628592097898498
See also terser/html-minifier-terser#87
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
dogfood preview
https://deploy-preview-5629--docusaurus-2.netlify.app/tests/pages/hydration-tests
(it used to fail and href of first link was wrong before the fix was applied)