Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): reset default style for task lists #5643

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

EkaterinaMozheiko
Copy link
Contributor

@EkaterinaMozheiko EkaterinaMozheiko commented Oct 3, 2021

Motivation

Resolve #5409

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I fixed displaying of the list
Screenshot from 2021-10-03 18-37-02

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@netlify
Copy link

netlify bot commented Oct 3, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: d36303c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6159c2085df982000798935e

😎 Browse the preview: https://deploy-preview-5643--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 71
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5643--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 3, 2021
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all right, just let's fix minor nits.

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Oct 3, 2021
@EkaterinaMozheiko
Copy link
Contributor Author

@lex111, done!

@lex111 lex111 changed the title fix(theme-classic): fix markdown list style fix(theme-classic): reset default style for task lists Oct 3, 2021
@lex111 lex111 merged commit 7b3daee into facebook:main Oct 3, 2021
@lex111
Copy link
Contributor

lex111 commented Oct 3, 2021

@EkaterinaMozheiko awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task lists are rendered as disabled and with dashes
3 participants