feat(theme-classic): make first tab the default tab #5647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's quite weird UX to display no tabs if no
default
has been provided—how many users would want only headings with no content anyways? (This behavior is still achievable with<Tabs defaultValue="none">
)A further fix I can think of is to throw an error when
defaultValue
is non-existent, and usedefaultValue={null}
to specially indicate no tabs open by default. This helps to catch typos early. But that could be a minor BC. (The current fix is already a minor behavior inconsistency, but probably with little effect)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Updated all the tabs usage on the website.