Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore duplicate Tabs rendering to fix hydration issue #5652

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 6, 2021

Motivation

Restore tabs duplicate rendering to fix hydration issue

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

deploy preview test page:

https://deploy-preview-5652--docusaurus-2.netlify.app/tests/pages/tabs-tests

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 6, 2021
@slorber slorber requested a review from lex111 as a code owner October 6, 2021 17:26
@netlify
Copy link

netlify bot commented Oct 6, 2021

✔️ [V2]

🔨 Explore the source changes: db8ac1e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/615dddc98dbb34000765f16a

😎 Browse the preview: https://deploy-preview-5652--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 84
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5652--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Size Change: +290 B (0%)

Total Size: 834 kB

Filename Size Change
website/build/assets/js/main.********.js 420 kB +288 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.3 kB 0 B
website/build/assets/css/styles.********.css 93.9 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB 0 B
website/build/blog/index.html 38.1 kB 0 B
website/build/docs/index.html 44.6 kB +1 B (0%)
website/build/docs/installation/index.html 52.8 kB +1 B (0%)
website/build/index.html 30.8 kB 0 B
website/build/tests/docs/index.html 25.5 kB 0 B
website/build/tests/docs/standalone/index.html 22.9 kB 0 B

compressed-size-action

@slorber slorber merged commit e1b4da0 into main Oct 7, 2021
@slorber slorber deleted the slorber/dynamic-default-tab-issue branch October 7, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants