chore: upgrade Infima to alpha.34

[lex111]

Motivation

Of the important changes, navbar logo is wrapped in separate div.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

[github-actions]

Size Change: +56 B (0%)

Total Size: 837 kB

ℹ️ View Unchanged

Filename	Size	Change
website/.docusaurus/globalData.json	38.3 kB	0 B
website/build/assets/css/styles.********.css	93.9 kB	+20 B (0%)
website/build/assets/js/main.********.js	421 kB	0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html	67 kB	+6 B (0%)
website/build/blog/index.html	38.1 kB	+6 B (0%)
website/build/docs/index.html	45 kB	+3 B (0%)
website/build/docs/installation/index.html	53.4 kB	+3 B (0%)
website/build/index.html	30.8 kB	+6 B (0%)
website/build/tests/docs/index.html	26.2 kB	+6 B (0%)
website/build/tests/docs/standalone/index.html	22.9 kB	+6 B (0%)

_{compressed-size-action}

[netlify]

✔️ [V2]

🔨 Explore the source changes: 9586fa7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61605af0fd8eb20008217db8

😎 Browse the preview: https://deploy-preview-5666--docusaurus-2.netlify.app

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	96
🟢 Accessibility	98
🟢 Best practices	100
🟢 SEO	100
🟢 PWA	95

Lighthouse ran on https://deploy-preview-5666--docusaurus-2.netlify.app/

[slorber]

do we really need to handle this case? we don't have it in our codebase

I think this component is quite messy and it's only used twice, for mobile/desktop sidebars with exact same props:

          <Logo
            className="navbar__brand"
            imageClassName="navbar__logo"
            titleClassName="navbar__title"
          />

What about replacing this with <NavbarLogo> and apply classes inside of it?

I don't think this component is meant to be used in any other place so I'd rather make the coupling to navbar more explicit

(this is technically a theme breaking but I think we should do it. Can be in another PR though)

[lex111]

Yes, this component has another use case:

docusaurus/packages/docusaurus-theme-classic/src/theme/DocSidebar/index.tsx

Line 76 in 7868df1

{hideOnScroll && <Logo tabIndex={-1} className={styles.sidebarLogo} />}

[slorber]

thanks, didn't see it

still, not a fan at all of adding/removing the extra div when adding/removing the imageClassName => this is not explicit and not an expected side-effect of using this prop: it should just apply a className or not

Also, the 3 places where this comp is used look exactly the same. I don't really understand why this DocSidebar thing can't use the same classes as the navbar.

Going to merge now but I think there's some additional cleanup we could do on this comp

[slorber]

LGTM, didn't see any issue apart some useless code in Logo, but cleanup can be done in a separate PR