Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove a few Lodash usages & ESLint enforcement #5807

Merged
merged 6 commits into from Oct 28, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

A lot of the Lodash methods have their ES counterparts, which are more concise and straightforward (because they are defined on the prototype). Some of them are now forbidden with ESLint rule configuration.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Minor refactor, everything should still work

Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Oct 28, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 28, 2021
@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 4c855b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617a244119e236000a96863d

😎 Browse the preview: https://deploy-preview-5807--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 28, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 87
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5807--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit 7a6607c into facebook:main Oct 28, 2021
@Josh-Cena Josh-Cena deleted the remove-lodash branch October 28, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants