Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clear a few ESLint warnings #5808

Merged
merged 2 commits into from Oct 28, 2021
Merged

refactor: clear a few ESLint warnings #5808

merged 2 commits into from Oct 28, 2021

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Oct 28, 2021 •
edited

Motivation

  1. Errors should have better typing instead of any.
  2. Module aliases with type any are acceptable.
  3. According to refactor(module-type-aliases): remove fallback aliases #5726 (comment) the props for NotFound should be removed.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview & test

@Josh-Cena
refactor: clear a few ESLint warnings
30b8278 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@Josh-Cena
Fix
f215abc
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 28, 2021
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Oct 28, 2021
@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: f215abc

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617a2057cac6250008c2f431

😎 Browse the preview: https://deploy-preview-5808--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 71
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5808--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Oct 28, 2021
@Josh-Cena Josh-Cena merged commit 4b2152a into facebook:main Oct 28, 2021
@Josh-Cena Josh-Cena deleted the eslint-any branch October 28, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@slorber slorber Awaiting requested review from slorber slorber is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Josh-Cena @facebook-github-bot