Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add patrikmasiar website showcase #5875

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Conversation

patrikmasiar
Copy link
Contributor

@patrikmasiar patrikmasiar commented Nov 4, 2021

Motivation

Create clean documentation of my projects and try new technology based on React JS.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

N/A showcase only

Related PRs

Nono

@facebook-github-bot
Copy link
Contributor

Hi @patrikmasiar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Nov 4, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: da38880

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/618436fe3478520008bdce9c

😎 Browse the preview: https://deploy-preview-5875--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5875--docusaurus-2.netlify.app/

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 4, 2021
@Josh-Cena
Copy link
Collaborator

I'd prefer that you have more contents on the website before adding it to the showcase

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 5, 2021
@slorber
Copy link
Collaborator

slorber commented Nov 5, 2021

Thanks

looks like @patrikmasiar is actively adding more content and linked to it from its main homepage/domain, so I'm interpolating that this site will be complete soon, that seems good enough for me to merge

@slorber slorber merged commit 9c086d4 into facebook:main Nov 5, 2021
@patrikmasiar
Copy link
Contributor Author

@Josh-Cena @slorber Thank you for noticing.
Yes, I am actively working on the website so the content will be fully-added soon.

Thank you for your review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants